Conversation
|
This is literally the best thing ever for the Feed Me, can't wait for this to be merged! |
|
Hey @i-just, I was trying to install this branch to see how I could integrate this wit Scout but I see it requires Craft 4 here https://github.com/craftcms/feed-me/blob/feature/1584-batched-job/composer.json#L33 but the PR is against the 5.x branch. Will this be merged for both or it something wrong with that? Thanks! |
|
Hi @janhenckens, if approved, this will be merged into Feed Me 5.x (for Craft CMS 4) and Feed Me 6.x (for Craft CMS 5). |
Oh, my bad - I got the plugin & craft versions confused. |
|
Hope it does get approved. Queues with low TTR or data that isn't able to be paginated will benefit greatly with batched job support natively from Feed Me. |
|
Sorry to disturb, but it would be really great to have this pull request approved! This feature would be super helpful 🤞 |
|
This is a draft PR and isn’t finalized, yet. |
|
Just released Feed Me 5.11.0 and 6.8.0 with this. |
|
Amazing! |
Description
Feeds are now processed as batched jobs.
Notes:
services/Process.php->processFeed()- the last parameter ($feedData) is no longer optionalservices/Process.php->afterProcessFeed()- now accepts the 4th param ($startTime); it’s needed for the time calculations to work correctly for the paginated view; if omitted, the time calculation will still work, but as before - timing only the last pageservices/Process.php->beforeProcessFeed()is now split into 2 methods,beforeProcessFeed(), which runs before each page (if the feed is not paginated, then there’s only one page), andgetFeedSettings(), which runs before each batchProcessing X elements finished in <number>s=> it looks like this was a bit buggy before for paginated feeds; it reported the total number of processed items but only really measured the time of the past page (fixed now)Finished preparing for feed processing.because the$stepKeywas not cleared as expected (fixed now)Related issues
#1584